Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump REQUIRED_VERSION #396

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Conversation

rekterakathom
Copy link
Contributor

When merged this pull request will: Title

  1. Describe what this pull request will do
    Set the correct required version. I believe the latest command on master is getOrDefaultCall which was introduced in A3 version 2.12

  2. Each change in a separate line
    Title

The whole version check might be disabled(?) but it's good practice to keep it up-to-date I suppose.

getOrDefaultCall requires 2.12
@jokoho48
Copy link
Collaborator

jokoho48 commented May 20, 2024

Maybe we should push it to the latest(what should be 2.16) instead of the "minimum Required" version

@rekterakathom
Copy link
Contributor Author

rekterakathom commented May 20, 2024

Maybe we should push it to the latest(what should be 2.16) instead of the "minimum Required" version

Not a bad idea either. Maybe edit this PR to match the latest version when releasing 2.6.1, so 2.16 or 2.18, and then merge.

@jokoho48 jokoho48 merged commit 7c38231 into nk3nny:master Jul 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants