Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] AI Profiles #164

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

[WIP] AI Profiles #164

wants to merge 19 commits into from

Conversation

jokoho48
Copy link
Collaborator

@jokoho48 jokoho48 commented Oct 1, 2020

No description provided.

@jokoho48 jokoho48 requested review from nk3nny and diwako October 2, 2020 12:13
@jokoho48 jokoho48 added this to the 2.5.0 milestone Oct 2, 2020
@jokoho48 jokoho48 added this to In progress in 2.5.0 via automation Oct 2, 2020
class LAMBS_CfgAIProfiles {
class Default {
#ifdef ISDEV
allowDemoNumberAsBool = 1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the profile stuff is in the main component, wouldn't it be better to have the dev values in danger and the actual prod default values in main?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would split it into the modules where it is used

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need then at least in the wiki some entry with all config entries. It is confusing to look at the code and only see a fraction of possible entries. (Or we have to tell people to use the config viewer)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

originally I planned to build a tool that shows and allows you to create and modify profiles in the editor in the release after the profiles where introduced. but writing a small export for the wiki is also fairly easy

*/
params [["_target", objNull, [objNull, grpNull]], ["_tactic", "unkown", [""]]];

private _profile = _target getVariable [QGVAR(AIProfile), "default"];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of a QoL thing. Have a cba setting which profile should be used as default

the CBA setting is a list of available profiles

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a dropdown would be impossible because they can be saved in the description and created via scripted modules. and parsing that while in the editor is from my knowledge not possible. the only thing for CBA setting we could do is a normal text box.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I see it, is, a drop down is doable, but only account for config and missionconfig profiles. If someone adds them in editor OR via script it is in their authority to set the default correctly.

addons/main/functions/Profiles/fnc_doesProfileAllow.sqf Outdated Show resolved Hide resolved
@jokoho48 jokoho48 marked this pull request as draft October 3, 2020 00:09
@jokoho48 jokoho48 changed the title AIProfiles [WIP] AI Profiles Oct 3, 2020
@jokoho48 jokoho48 modified the milestones: 2.5.0, 2.6.0 Oct 6, 2020
@jokoho48 jokoho48 added this to To do in 2.7.0 via automation Oct 6, 2020
@jokoho48 jokoho48 removed this from In progress in 2.5.0 Oct 6, 2020
@jokoho48 jokoho48 moved this from To do to In progress in 2.7.0 Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.7.0
In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants