Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tile_blocksize() to work with multi-layer rasters #90

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented Aug 21, 2024

Closes #87 by using only the first row of output from terra::fileBlocksize(), which outputs a number of rows and columns for each layer.

@Aariq Aariq requested a review from njtierney September 3, 2024 21:24
@njtierney
Copy link
Owner

This looks good to me - can you add a NEWS bullet to link to issues #87 and #89 ?

@Aariq
Copy link
Collaborator Author

Aariq commented Sep 9, 2024

I added some issue numbers to NEWS, but I'll point out that this is still the version where tile_blocksize() was first introduced, so from that point of view it's not really a bug fix, but just actually properly implementing things.

@njtierney
Copy link
Owner

Yup, totally agree this isn't really a bug fix per se. Thanks for adding those! I'm happy for you to merge this :)

@Aariq Aariq merged commit 68e425f into master Sep 10, 2024
7 checks passed
@Aariq Aariq deleted the fix-tile_blocksize branch September 10, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tile_blocksize() may fail with multi-layer rasters
2 participants