Rename tar_<filetype>() to tar_<pkg>_<data type>() #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aariq
commented
Mar 7, 2024
Aariq
changed the title
filetype option
|
I really like the idea of having |
njtierney
reviewed
Mar 11, 2024
Aariq
changed the title
filetype optionMerge commit '33a6ca313d2aec15d99fb7553b4a655c949640cc' #Conflicts: # NAMESPACE # R/tar-geotiff.R # R/tar-shapefile.R # man/geotargets-package.Rd
|
Looks good! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
tar_geotiff()totar_terra_rast(). It separates out the format into a new function,format_terra_rast()that returns the output of atar_format()call.I separated it out so it could accept afiletypeargument where users can choose a GDAL driver (from a list of possibilities we have implemented and tested withtargets).I'm thinking maybe we'll end up having tar_ functions like
tar_<pkg name>_<data type/class>()with some default storage formats rather than naming the functions after the file type. What do you think?Somewhat addresses #4