Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass user specified resources #67

Merged
merged 10 commits into from
May 13, 2024
Merged

Pass user specified resources #67

merged 10 commits into from
May 13, 2024

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented May 9, 2024

Fix for #66. Uses utils::modifyList() to append the user supplied resources with those necessary for tar_terra_*() to work. Also includes changes to tests that were needed to get check() to pass

@Aariq Aariq requested a review from njtierney May 9, 2024 20:04
@Aariq Aariq mentioned this pull request May 9, 2024
Copy link
Owner

@njtierney njtierney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just a couple of changes!

R/tar-terra-rast.R Outdated Show resolved Hide resolved
R/tar-terra-sprc.R Outdated Show resolved Hide resolved
R/tar-terra-vect.R Outdated Show resolved Hide resolved
@Aariq Aariq requested a review from njtierney May 10, 2024 16:20
Copy link
Owner

@njtierney njtierney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Feel free to merge when ready

@Aariq Aariq merged commit 4af63c5 into master May 13, 2024
7 checks passed
@Aariq Aariq deleted the resources-fix branch May 13, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User input resources not being passed from tar_terra_*() to tar_target_raw()
2 participants