Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tar_terra_sprc() simplification #65

Merged
merged 8 commits into from
May 3, 2024
Merged

tar_terra_sprc() simplification #65

merged 8 commits into from
May 3, 2024

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented Apr 29, 2024

Removes some repeated or unnecessary code I noticed in tar_terra_sprc(). Implements suggestion in #61.

@Aariq
Copy link
Collaborator Author

Aariq commented Apr 30, 2024

I'm not sure semicolon_split() and semicolon_paste() were worth it because it seems difficult to use unexported functions inside read/write functions of custom formats.

@Aariq Aariq requested a review from njtierney April 30, 2024 20:21
@njtierney
Copy link
Owner

I feel you re the semicolon_paste/split functions - they feel like they should be useful but I can understand that in this context they don't really help!

Copy link
Owner

@njtierney njtierney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, happy to merge when you like :)

@Aariq Aariq merged commit 31d7c6d into master May 3, 2024
7 checks passed
@Aariq Aariq deleted the tar_terra_sprc-refactor branch May 3, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants