Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geotargets options / defaults update #30

Merged
merged 7 commits into from
Mar 15, 2024

Conversation

brownag
Copy link
Contributor

@brownag brownag commented Mar 15, 2024

Some updates to options following #19 for #26

R/geotargets-option.R Outdated Show resolved Hide resolved
Copy link
Owner

@njtierney njtierney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Co-authored-by: Nicholas Tierney <[email protected]>
@njtierney
Copy link
Owner

Really nice work! I believe this resolves #25 #26 ?

It looks like it handles all we need for those issues to me. We can come back to #27 in a separate PR I think. Are you happy for me to merge?

@brownag
Copy link
Contributor Author

brownag commented Mar 15, 2024

Really nice work! I believe this resolves #25 #26 ?

It looks like it handles all we need for those issues to me. We can come back to #27 in a separate PR I think. Are you happy for me to merge?

Thanks. Last thing was I realized that ENCODING as a default creation option for GTiff doesn't make sense... that is the default for terra::writeVector() but few or no raster drivers support it anyway. Should be good to merge if you are happy with it

@njtierney
Copy link
Owner

Yup! Awesome 🚀

@njtierney njtierney merged commit b16bea4 into njtierney:master Mar 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants