simple solution to #64

njtierney · Apr 29, 2024 · e1b039f · e1b039f
1 parent c148f7b
commit e1b039f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/R/geotargets-option.R b/R/geotargets-option.R
@@ -38,10 +38,10 @@ geotargets_option_set <- function(
 ) {
 
     options(
-        "geotargets.gdal.raster.driver" = gdal_raster_driver,
-        "geotargets.gdal.raster.creation.options" = gdal_raster_creation_options,
-        "geotargets.gdal.vector.driver" = gdal_raster_creation_options,
-        "geotargets.gdal.vector.creation.options" = gdal_raster_creation_options
+        "geotargets.gdal.raster.driver" = gdal_raster_driver %||% geotargets_option_get("gdal.raster.driver"),
+        "geotargets.gdal.raster.creation.options" = gdal_raster_creation_options %||% geotargets_option_get("gdal.raster.creation.options"),
+        "geotargets.gdal.vector.driver" = gdal_vector_driver %||% geotargets_option_get("gdal.vector.driver"),
+        "geotargets.gdal.vector.creation.options" = gdal_vector_creation_options %||% geotargets_option_get("gdal.vector.creation.options")
     )
 
 }

diff --git a/tests/testthat/test-geotargets-option.R b/tests/testthat/test-geotargets-option.R
@@ -25,3 +25,9 @@ test_that("geotargets_option_set() works", {
     expect_equal(geotargets_option_get("gdal_raster_driver"), "COG")
 })
 
+test_that("options aren't reset with multiple calls to geotargets_option_set()", {
+    geotargets_option_set(gdal_raster_driver = "GPKG")
+    geotargets_option_set(gdal_vector_driver = "GPKG")
+    expect_equal(geotargets_option_get("gdal_vector_driver"), "GPKG")
+    expect_equal(geotargets_option_get("gdal_raster_driver"), "GPKG")
+})