Merge pull request #47 from njtierney/covr-check-pkg-installed-46

Add test coverage for check_pkg_installed
njtierney · Mar 24, 2024 · 66d027d · 66d027d
2 parents 3429b79 + 8b48c44
commit 66d027d
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 4 deletions.
diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml
@@ -44,7 +44,7 @@ jobs:
           extra-packages: any::rcmdcheck
           needs: check
 
-      - uses: r-lib/actions/check-r-package@v2
+      - uses: r-lib/actions/check-r-package@v2.8.3
         with:
           upload-snapshots: true
           build_args: 'c("--no-manual","--compact-vignettes=gs+qpdf")'
diff --git a/R/tar-terra-vect.R b/R/tar-terra-vect.R
@@ -124,9 +124,7 @@ create_format_terra_vect <- function(filetype, options, ...) {
 
     drv <- get_gdal_available_driver_list("vector")
 
-    if (is.null(filetype)) {
-        filetype <- "GeoJSON"
-    }
+    filetype <- filetype %||% "GeoJSON"
 
     filetype <- match.arg(filetype, drv$name)
 

diff --git a/tests/testthat/_snaps/check-pkg-installed.md b/tests/testthat/_snaps/check-pkg-installed.md
@@ -0,0 +1,8 @@
+# check_pkg_installed() works
+
+    Code
+      check_pkg_installed("asdf")
+    Condition
+      Error:
+      ! package asdf is required
+
diff --git a/tests/testthat/test-check-pkg-installed.R b/tests/testthat/test-check-pkg-installed.R
@@ -0,0 +1,7 @@
+test_that("check_pkg_installed() works", {
+  expect_snapshot(
+      error = TRUE,
+      x = check_pkg_installed("asdf")
+  )
+  expect_null(check_pkg_installed("targets"))
+})