Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htop: write-protect entire configuration directory #5553

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

9ary
Copy link
Contributor

@9ary 9ary commented Jun 19, 2024

Description

As of htop-dev/htop@5e8fc97, htop creates a new config file and renames it over home-manager's symlink. This PR works around this by moving the whole $XDG_CONFIG_HOME/htop directory into the nix store, preventing such overwrites.

Checklist

  • Change is backwards compatible. (it isn't, activation will fail with Existing file '$XDG_CONFIG_HOME/htop' is in the way of '/nix/store/...-home-manager-files/.config/htop')

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@bjpbakker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant