htop: write-protect entire configuration directory #5553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of htop-dev/htop@5e8fc97, htop creates a new config file and renames it over home-manager's symlink. This PR works around this by moving the whole $XDG_CONFIG_HOME/htop directory into the nix store, preventing such overwrites.
Checklist
Change is backwards compatible. (it isn't, activation will fail with
Existing file '$XDG_CONFIG_HOME/htop' is in the way of '/nix/store/...-home-manager-files/.config/htop'
)Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@bjpbakker