mu: add support for setting muhome #5535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The database path can be set by the user, this is useful for keeping the Maildir and the Mu Xapian cache together without affecting XDG_CACHE_HOME Fixes nix-community#5534. Signed-off-by: J. Dekker <[email protected]>
rycee
reviewed
Jul 1, 2024
| @@ -31,6 +31,15 @@ in { | |||
|
|
|||
| package = mkPackageOption pkgs "mu" { }; | |||
|
|
|||
| home = mkOption { | |||
| type = with types; nullOr str; | |||
| default = null; | |||
There was a problem hiding this comment.
Maybe the default should be "${config.xdg.cacheHome}/mu" and --muhome always used? Note, if we do this then also need to add defaultText to avoid making documentation depend on the configuration.
There was a problem hiding this comment.
I like null to unset values such that the default is used, though maybe in the case of null we should just remove the --muhome argument entirely. That being said it doesn't matter to me either way, which would you prefer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The database path can be set by the user, this is useful for keeping
the Maildir and the Mu Xapian cache together without affecting
XDG_CACHE_HOME. Fixes #5534.
Note that this is untested apart from the test suite. I'm not entirely sure how to easily test a home-manager change when it's a module within my NixOS configuration temporarily.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@Karljo