Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

programs.pywal: init #2949

Merged
merged 2 commits into from
May 10, 2022
Merged

programs.pywal: init #2949

merged 2 commits into from
May 10, 2022

Conversation

teto
Copy link
Collaborator

@teto teto commented May 9, 2022

pywal allows to change your theme for much software:
https://github.com/dylanaraps/pywal/wiki/Customization#table-of-contents

home-manager is the perfect tool to leverage since a single setting
could enable wal-compatible theming for all this software.

In this PR, I've just enabled zsh, kitty and i3 but I hope follow up PRs will
enable more software.
At some point we may even need a blacklist.

Once enabled, run:
wal --theme random

to change your colorschemes.

edit: for neovim support we would need dylanaraps/wal.vim#26

Description

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

pywal allows to change your theme for much software:
https://github.com/dylanaraps/pywal/wiki/Customization#table-of-contents

home-manager is the perfect tool to leverage since a single setting
could enable wal-compatible theming for all this software.

In this PR, I've just enabled zsh, kitty and i3 but I hope follow up PRs will
enable more software.
At some point we may even need a blacklist.

Once enabled, run:
wal --theme random

to change your colorschemes.
modules/programs/pywal.nix Outdated Show resolved Hide resolved
@rycee
Copy link
Member

rycee commented May 9, 2022

Thanks, looks fine to me! Just a few minor comments.

@berbiche
Copy link
Member

berbiche commented May 9, 2022

At some point we may even need a blacklist.

What if we had an option that enables/disables it by default for every tool and then manually enable it?

@berbiche
Copy link
Member

berbiche commented May 9, 2022

There was a similar PR last year for a tool called "Flavours", see #2165

@teto
Copy link
Collaborator Author

teto commented May 9, 2022

What if we had an option that enables/disables it by default for every tool and then manually enable it?

that's my intention. I wanted to merge initial support so that others can join in the effort plus it makes other additions easier.

here was a similar PR last year for a tool called "Flavours", see #2165

I had completely missed it thanks interesting. Looking forward to that PR being reopened :)

@teto teto merged commit f735a85 into nix-community:master May 10, 2022
@teto teto deleted the pywal branch May 10, 2022 20:24
@teto
Copy link
Collaborator Author

teto commented May 11, 2022

damn I realized I had a copy of the module in my dotfiles and realized that after removing it could not load the pywal module from HM. I''ve also found an issue with rofi and have added neovim support locally. Please dont revert, I will fix soon

montchr added a commit to montchr/home-manager that referenced this pull request May 17, 2022
commit dce4a3d
Author: Chris Montgomery <[email protected]>
Date:   Tue Apr 5 22:44:12 2022 -0400

    gpg-agent: add option to specify pinentry package

    this is useful for macOS, where `pkgs.pinentry_mac` may be preferable to
    one of the `pkgs.pinentry` flavors.

commit 9ee03d5
Author: Chris Montgomery <[email protected]>
Date:   Wed Mar 16 10:54:19 2022 -0400

    gpg-agent: add launchd service for darwin

commit 32a7da6
Author: Peng Guanwen <[email protected]>
Date:   Thu May 5 09:14:02 2022 +0200

    Translate using Weblate (Chinese (Simplified))

    Currently translated at 85.7% (12 of 14 strings)

    Co-authored-by: Peng Guanwen <[email protected]>
    Translate-URL: https://hosted.weblate.org/projects/home-manager/modules/zh_Hans/
    Translation: Home Manager/Home Manager Modules

commit 273598f
Author: Sumner Evans <[email protected]>
Date:   Fri May 13 08:27:23 2022 -0600

    mako: add package option (nix-community#2955)

commit f735a85
Author: Matthieu Coudron <[email protected]>
Date:   Tue May 10 22:24:19 2022 +0200

    programs.pywal: init (nix-community#2949)

commit 4293902
Author: Markus Scherer <[email protected]>
Date:   Tue May 10 09:30:40 2022 +0200

    offlineimap: remove dependency on python2 (nix-community#2909) (nix-community#2951)

commit 882bd81
Author: Aidan Gauland <[email protected]>
Date:   Sat May 7 13:27:31 2022 +1200

    gtk: Update example strings for gtk.theme.package (nix-community#2904)

    - Change the example value of `gtk.theme.package` from
    `pkgs.gnome.gnome_themes_standard` was an alias that was removed on 2022-01-13,
    `pkgs.gnome-themes-extra`, which references the actual package.

    - Change the example value of `gtk.icon.package` from `pkgs.adwaita-icon-theme` to
    `pkgs.gnome.adwaita-icon-theme`, as this package is in the `gnome` package set.
jevy pushed a commit to jevy/home-manager that referenced this pull request Jul 1, 2022
@Misterio77
Copy link
Contributor

You might be interested in nix-colors. It's something I came up with to replace flavours in my home-manager setup :)

@teto teto mentioned this pull request Aug 22, 2022
7 tasks
teto added a commit to teto/home-manager that referenced this pull request Aug 22, 2022
spacekookie pushed a commit to spacekookie/home-manager that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants