Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactor for V3 #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Major refactor for V3 #58

wants to merge 2 commits into from

Conversation

manveru
Copy link
Collaborator

@manveru manveru commented Jun 28, 2019

This is a rather big PR, I worked on it for several days but think it's ready for some public scrutiny now.

Biggest changes are:

  • Completely new CLI that actually provides some documentation as well
  • All commands are now subcommands, the old bundix behaviour now is bundix lockfile (this is still up for discussion, as it's gonna break a ton of scripts)
  • It's possible to generate Gemfile and Gemfile.lock now, even for only specific groups.
  • bundix init now uses mkShell
  • default.nix now uses bundlerEnv because I love recursion. Should figure out a way to make bundlerApp work in this scenario as well.
  • Optionally generate JSON gemsets. They aren't consumed by anything yet and it's a good chance to take a closer look at how to make the existing format a bit better.
  • Added platform to the lockfile, this also needs testing to see how it behaves on windows/darwin.
  • Way more test coverage and some fixed tests, check with COVERAGE=1 rake.

Please let me know what you think.

@manveru manveru requested review from zimbatm and alyssais June 28, 2019 10:31
@manveru manveru self-assigned this Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant