Add support for platform windows #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjlarose
commented
Feb 8, 2024
| @@ -68,6 +68,7 @@ def groups(spec, dep_cache) | |||
| "mingw" => [{engine: "mingw"}], | |||
| "truffleruby" => [{engine: "ruby"}], | |||
| "x64_mingw" => [{engine: "mingw"}], | |||
| "windows" => [{engine: "mswin"}, {engine: "mswin64"}, {engine: "mingw"}], | |||
There was a problem hiding this comment.
Wasn't 100% sure what engines to list here, but basically took the list from Gem::Platform::WINDOWS as defined here
|
@inscapist would we be able to get this merged into your fork? |
|
For context it looks like “windows” was added as an alias for existing windows platforms in bundler: rubygems/rubygems#5650 I encountered the issue as new Rails app Gemfiles use this alias instead of the mingX platforms it did before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57
Several gems declare platform support for
windows, including several dependencies of a newly-generatedrailsapp