Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Constants folder #46

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

eylonshm
Copy link

Create Constants folder and move some code into it.

Create Constants folder and move code into it
@eylonshm eylonshm mentioned this pull request Jul 23, 2023
@nitzano nitzano changed the title Add Constants folder fix: add Constants folder Aug 5, 2023
@eylonshm
Copy link
Author

eylonshm commented Aug 5, 2023

@nitzano I think now it'll work well.

@nitzano
Copy link
Owner

nitzano commented Aug 12, 2023

@eylonshm : Doesn't pass lint yet, can you please run it locally?

https://github.com/nitzano/react-reading-panel/actions/runs/5832909525/job/15841625049?pr=46

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this file deleted?

Copy link
Author

@eylonshm eylonshm Aug 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's no actual use of it's only function @nitzano.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants