Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gcp): Batch services #676

Merged
merged 17 commits into from
Oct 3, 2024
Merged

feat(gcp): Batch services #676

merged 17 commits into from
Oct 3, 2024

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented Sep 9, 2024

Implementation of Nitric batch-services on GCP

@tjholm tjholm changed the title feat(gcp): Batch feat(gcp): Batch services Sep 9, 2024
@tjholm tjholm force-pushed the feat/batch-gcp branch 2 times, most recently from a154b6a to 41ada3f Compare September 12, 2024 22:52
@tjholm tjholm marked this pull request as ready for review September 12, 2024 22:53
@tjholm tjholm force-pushed the feat/batch-gcp branch 2 times, most recently from 137584f to b0b7c8c Compare September 13, 2024 00:00
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feat/batch@5b6d79c). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff              @@
##             feat/batch     #676   +/-   ##
=============================================
  Coverage              ?   48.62%           
=============================================
  Files                 ?       27           
  Lines                 ?     3391           
  Branches              ?        0           
=============================================
  Hits                  ?     1649           
  Misses                ?     1637           
  Partials              ?      105           
Flag Coverage Δ
aws 44.10% <ø> (?)
azure 53.29% <ø> (?)
core 60.94% <ø> (?)
gcp 47.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjholm tjholm force-pushed the feat/batch-gcp branch 2 times, most recently from d2a82ed to 2628279 Compare October 1, 2024 03:42
@tjholm tjholm changed the base branch from main to feat/batch October 2, 2024 04:18
@tjholm tjholm merged commit 2bf6a7f into feat/batch Oct 3, 2024
2 checks passed
@tjholm tjholm deleted the feat/batch-gcp branch October 3, 2024 06:06
jyecusch added a commit that referenced this pull request Oct 3, 2024
* Add Batch API to nitric core
* feat(aws): Batch services (#675)
* feat(gcp): Batch services (#676)

---------

Co-authored-by: Jye Cusch <[email protected]>
Co-authored-by: David Moore <[email protected]>
Co-authored-by: Ryan Cartwright <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants