Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gcp sql database support #623

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: gcp sql database support #623

wants to merge 4 commits into from

Conversation

HomelessDinosaur
Copy link
Member

No description provided.

tjholm
tjholm requested changes Jun 14, 2024
View reviewed changes
Copy link
Member

@tjholm tjholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes that fix a gateway to service timeout mismatch have been reverted in the PR.

cloud/gcp/deploy/api.go Outdated Show resolved Hide resolved
cloud/gcp/deploy/api.go Outdated Show resolved Hide resolved
cloud/gcp/deploy/api.go Outdated Show resolved Hide resolved
davemooreuws
davemooreuws requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First deploy works well.

But next ones don't apply the migrations at the correct time, the cloud run builds are triggered before the new image is available. I used prisma to test.

Also might need to include similar dependencies for deploying services after migrations, like these: #627

@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.88%. Comparing base (e92356d) to head (3f49cb1).

❗ Current head 3f49cb1 differs from pull request most recent head 0acb82a

Please upload reports for the commit 0acb82a to get more accurate results.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #623       +/-   ##
===========================================
+ Coverage   49.21%   77.88%   +28.66%     
===========================================
  Files          23        5       -18     
  Lines        3233      217     -3016     
===========================================
- Hits         1591      169     -1422     
+ Misses       1537       40     -1497     
+ Partials      105        8       -97
Flag Coverage Δ
aws ?
azure ?
core 77.88% <ø> (ø)
gcp ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jyecusch jyecusch force-pushed the gcp-sql-database-support branch 3 times, most recently from fd9c96d to 60acdcf Compare July 2, 2024 03:50
@HomelessDinosaur HomelessDinosaur mentioned this pull request Aug 22, 2024
Open
@HomelessDinosaur
add gcp sql support
d412884 
use pulumi gcp version with vpc network access

fix rebase issue and format fix

handle client close error


rebase with source id fix

add dependency to migration for each service deployed

rebase fixes

tidy

ensure correct container image is always used


add retry instead of using cloud build wait long running operation

fix build resource

remove unused build status code

handle error on artifact registry unauthorised

lint

add license file

add polling to retrieve latest metadata

add auth mechanism for pkg.dev deployments

correctly poll cloud build builds


add cpu config


add deletion policy config

lint and generate

generate
@HomelessDinosaur
generate terraform
5ea9462
davemooreuws
davemooreuws requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue with deletion policy found, see comments.

@davemooreuws
Copy link
Member

Last issue is making sure services are created after the cloud build run ends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemooreuws davemooreuws davemooreuws requested changes

@jyecusch jyecusch jyecusch approved these changes

@tjholm tjholm tjholm approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@HomelessDinosaur HomelessDinosaur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HomelessDinosaur @davemooreuws @jyecusch @tjholm