Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GOAWAY reason NO_ERROR in client-initiated graceful shutdown #312

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use GOAWAY reason NO_ERROR in client-initiated graceful shutdown #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae15108
Use GOAWAY reason NO_ERROR in client-initiated graceful shutdown
zuiderkwast May 11, 2023
e59a57d
Add GOAWAY NO_ERROR testcase in rfc7540_SUITE
zuiderkwast Sep 25, 2023
05dce22
fixup: update testcase to use new fun arity in init_origin
bjosv Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/gun_http2.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,6 +887,7 @@ closing(Reason0, State=#http2_state{socket=Socket, transport=Transport,
Reason = case Reason0 of
normal -> no_error;
owner_down -> no_error;
shutdown -> no_error;
_ -> internal_error
end,
case Transport:send(Socket, cow_http2:goaway(
Expand Down
19 changes: 19 additions & 0 deletions test/rfc7540_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,25 @@ settings_ack_timeout(_) ->
timer:sleep(6000),
gun:close(ConnPid).

graceful_shutdown_goaway_no_error(_) ->
doc("(...) an endpoint that sends GOAWAY with NO_ERROR during "
"graceful shutdown (...) RFC7540 6.8"),
%% NO_ERROR (0x0): The associated condition is not a result of an error.
%% For example, a GOAWAY might include this code to indicate graceful
%% shutdown of a connection. (RFC7540 7)
{ok, _, Port} = init_origin(tcp, http2, fun(Parent, _ListenSocket, Socket, _Transport) ->
%% Expect a GOAWAY with reason NO_ERROR.
{ok, <<_:24, 7:8, 0:8, 0:1, 0:31>>} = gen_tcp:recv(Socket, 9, 500),
{ok, <<0:1, LastStreamId:31, ErrorCode:32>>} = gen_tcp:recv(Socket, 8, 500),
0 = LastStreamId,
0 = ErrorCode,
Parent ! done
end),
{ok, ConnPid} = gun:open("localhost", Port, #{protocols => [http2]}),
{ok, http2} = gun:await_up(ConnPid),
gun:shutdown(ConnPid),
receive done -> ok end.

keepalive_tolerance_ping_ack_timeout(_) ->
doc("The PING frame may be used to easily test a connection. (RFC7540 8.1.4)"),
{ok, OriginPid, OriginPort} = init_origin(tcp, http2, do_ping_ack_loop_fun()),
Expand Down
Loading