conditional compilation of gcd(SomeInteger,SomeInteger) in std/math #23773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
most specific version of gcd(int,int) uses bitwise comparisons that are not available in non-node js. Conditional compliation should fix the issue here and in other downstream libraries like std/rationals
conditional compilation of gcd(SomeInteger, SomeInteger) in std/math
Araq
reviewed
Jul 8, 2024
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most specific version of
gcd(int,int)instd/mathuses bitwise comparisons from C compilers, which can't be borrowed on the js platform in the web browser. Conditional compilation here should fix the issue for this and downstream libraries such asstd/rationalswhen compiling to browser js as the backend.