Makefile: fix lib rule #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace between literal and string macro [-Wliteral-suffix]
fixed GCC 6.3 warning: invalid suffix on literal; C++11 requires a sp…
RPath needed by MacOSX was not correctly set for minisat. Therefore it was not correctly linked against STP.
Fix linking of minisat as dependency library on MacOSX
On 64bit systems, the usual destination for libraries is /usr/lib64, not /usr/lib. So add CMAKE_INSTALL_LIBDIR and allow overriding the the default.
Build static lib only if BUILD_STATIC_LIBS is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the rule for dynamic library is run in parallel (using make -jX),
it can overwrite one file multiple times resulting in errors like:
build/dynamic/lib/libminisat.so: file not recognized: File format not recognized
Fix it by splitting and making an explicit dependency in Makefile.
Signed-off-by: Jiri Slaby [email protected]