Solution to issue #16 (illegal friend declaration of mkLit) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 28, 2014 10:44
|
This fix does not appear to have been merged into niklasso:master. I'm using Mac OS X 10.11.1, Apple LLVM version 7.0.0 (clang-700.1.76). [The fix appears to work, which I implemented manually based on this issue.] |
rusydi
added a commit
to rusydi/minisat
that referenced
this pull request
Mar 31, 2017
broesdecat
pushed a commit
to broesdecat/Minisatid
that referenced
this pull request
Apr 18, 2017
According to ISO C++11 standard: "If a friend declaration specifies a default argument expression, that declaration shall be a definition and shall be the only declaration of the function or function template in the translation unit.” Solved in the same way as the minisat project niklasso/minisat#17.
maelvls
added a commit
to maelvls/qute
that referenced
this pull request
Nov 12, 2017
According to ISO C++11 standard: "If a friend declaration specifies a default argument expression, that declaration shall be a definition and shall be the only declaration of the function or function template in the translation unit.” Solved in the same way as the minisat project niklasso/minisat#17: niklasso/minisat#17
maelvls
added a commit
to maelvls/qute
that referenced
this pull request
Nov 12, 2017
According to ISO C++11 standard: "If a friend declaration specifies a default argument expression, that declaration shall be a definition and shall be the only declaration of the function or function template in the translation unit.” Solved in the same way as the minisat project niklasso/minisat#17: niklasso/minisat#17
maelvls
added a commit
to maelvls/qute
that referenced
this pull request
Nov 12, 2017
According to ISO C++11 standard: "If a friend declaration specifies a default argument expression, that declaration shall be a definition and shall be the only declaration of the function or function template in the translation unit.” Solved in the same way as the minisat project niklasso/minisat#17: niklasso/minisat#17
|
This would be excellent to have this PR merged, for now this project does not compile anymore without this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves issue #16.
Basically, the friend declaration of mkLit is not needed, as mkLit can already access field x.
The specification of default value for the sign is moved to the definition of mkLit.