Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "FAQs" page to Trio Docs #99

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Conversation

Natolida
Copy link
Contributor

This PR replaces PR #81 and adds a FAQ page to Trio Docs.

  • I have updated the syntax of the Tips, Warning, etc, with the recent change to MkDocs.
  • I have confirmed that all links should be correct.

- Adds faq.md to resources folder
-Adds FAQ to Navigation
- Adjust some content to MkDocs formatting
- Updates links
Copy link
Contributor

@ebouchut ebouchut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Natolida

  • There is a broken link (an extra dot).
  • The 4-space indentation is missing for each line of the body text of each annotation

docs/resources/faq.md Outdated Show resolved Hide resolved
docs/resources/faq.md Outdated Show resolved Hide resolved
docs/resources/faq.md Outdated Show resolved Hide resolved
docs/resources/faq.md Outdated Show resolved Hide resolved
docs/resources/faq.md Outdated Show resolved Hide resolved
docs/resources/faq.md Outdated Show resolved Hide resolved
docs/resources/faq.md Outdated Show resolved Hide resolved
docs/resources/faq.md Outdated Show resolved Hide resolved
Corrects syntax for Tips, Warnings, Etc
Updates syntax of tips, warnings, etc
- Updated admonition syntax
- Fixes broken link
-Updated admonition
@ebouchut
Copy link
Contributor

Admonitions are now laid out correctly.
Thx @Natolida

I suggest you add Libre 2+ as supported CGMs (Cf. PR #95)

- Adds Libre 2+ to list of supported CGMs
@Natolida
Copy link
Contributor Author

Thanks for your assistance, @ebouchut!

I also thought of the Libre 2+ today and added it to the list.

This should be complete now and ready to be merged.

Copy link
Contributor

@MikePlante1 MikePlante1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a quick look at this, but I’ll give it a more thorough look later today.

docs/resources/faq.md Outdated Show resolved Hide resolved
docs/resources/faq.md Outdated Show resolved Hide resolved
docs/resources/faq.md Show resolved Hide resolved
docs/resources/faq.md Outdated Show resolved Hide resolved
- Fixes Typo
- Grammatical change
- Wording change Libre 2+ --> Libre 2 Plus as per @MikePlante1
- Changes spacing G6/ONE --> G6 / ONE as per  @MikePlante1
@Natolida
Copy link
Contributor Author

Thanks for the review, @MikePlante1.

In the previous PR #81 , @tmhastings wanted you to confirm something: Could you check out the information regarding Nightscout as a CGM source to ensure this is still valid or if it was sorted with one of the recent updates?

bullet lists seem to require an empty line before the first `* `
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants