Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update omnixxx submodules trio #445

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

marionbarker
Copy link
Contributor

Purpose:

These 8 improvements for OmniBLE/OmniKit are brought into trio. Most of the work was done by @itsmojo. I prepared the fix for Eros in which the clock icon was not provided when time zone does not match between phone and pod.

  • OmniBLE 4ad8117...fee22b3 (5):

    Merge pull request PR 138 from itsmojo/alternate-DASH-getStatus
    Merge pull request PR 137 from itsmojo/improved-PodMessageTransport-error-handling
    Merge pull request PR 136 from itsmojo/unacknowledge-command-improvement
    Merge pull request PR 135 from itsmojo/Omnipod-improvements
    Merge pull request PR 134 from itsmojo/OmniBLEParser-updates

  • OmniKit 01bc598...0857ad8 (3):

    Merge pull request PR 46 from loopandlearn/omnikit-add-clock-icon-main
    Merge pull request PR 45 from itsmojo/unacknowledge-command-improvement
    Merge pull request PR 44 from itsmojo/Omnipod-improvements

Status:

These have all been merged into LoopKit/OmniBLE:dev and LoopKit/OmniKit:main as well as the loopandlearn:OmniXXX:trio branch.

Testing:

  • Each individual PR was reviewed, tested and approved prior to merging.
  • Trio 0.2.2 dev was built with these modifications and works nominally

Copy link
Contributor

@dnzxy dnzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this in-vivo multiple days. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants