set createTime per node and purge old nodes if maxNodes is reached #57
Conversation
| @@ -512,6 +512,10 @@ func (d *DHT) needMoreNodes() bool { | |||
| return n < minNodes || n*2 < d.config.MaxNodes | |||
| } | |||
|
|
|||
| func (d *DHT) GetNumNodes() int { | |||
| return d.routingTable.numNodes() | |||
There was a problem hiding this comment.
Do we really need this? I don't think we do and I think it's better to only expose methods when we really need to. Besides, I think this isn't safe to be used concurrently while the DHT is running?
There was a problem hiding this comment.
agree. was just usefull for my debuging.
| @@ -206,6 +206,12 @@ func (r *routingTable) cleanup(cleanupPeriod time.Duration, p *peerStore) (needP | |||
| r.kill(n, p) | |||
| continue | |||
| } | |||
| // kill old and currently unused nodes if nodeCount is > maxNodes | |||
| if len(r.addresses) > p.maxNodes && time.Since(n.createTime) > cleanupPeriod && len(n.pendingQueries) == 0 { | |||
There was a problem hiding this comment.
I'd say we should kill the node even if there are pending queries. If it's so old, better refresh the routing table with newer models?
There was a problem hiding this comment.
we may have just sent out a query a second ago to that specific node, because of the nearest distance to the searched hash.. so we don't want to loose that result?
| @@ -105,13 +111,16 @@ func NewConfig() *Config { | |||
| MaxNodes: 500, | |||
| CleanupPeriod: 15 * time.Minute, | |||
| SaveRoutingTable: true, | |||
| PassivMode: false, | |||
There was a problem hiding this comment.
This is redundant with the RateLimit, right?
(In English we would spell it Passive, I think.)
| // max get_peer requests per hash to prevent infinity loop | ||
| MaxSearchQueries int | ||
| // number of concurrent listeners on same port | ||
| ConnPoolSize int |
There was a problem hiding this comment.
I don't think this will work? The code is not safe for concurrent use, right? If you want to use multiple goroutines you need different DHT instances
There was a problem hiding this comment.
as mentioned by email I broke my fork by commiting testing code and have no clue how to revert
|
discarded because broken. will create a new one. |
fixes #56