extract: support typed string constants (#304)

nicksnyder · Oct 5, 2023 · 5ee16aa · 5ee16aa
1 parent 8b7b3cb
commit 5ee16aa
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/v2/goi18n/extract_command.go b/v2/goi18n/extract_command.go
@@ -274,10 +274,12 @@ func extractStringLiteral(expr ast.Expr) (string, bool) {
 			}
 			return s, true
 		}
-		return "", false
-	default:
-		return "", false
+	case *ast.CallExpr:
+		if fun, ok := v.Fun.(*ast.Ident); ok && fun.Name == "string" {
+			return extractStringLiteral(v.Args[0])
+		}
 	}
+	return "", false
 }
 
 func i18nPackageName(file *ast.File) string {

diff --git a/v2/goi18n/extract_command_test.go b/v2/goi18n/extract_command_test.go
@@ -229,6 +229,25 @@ zero = "Zero translation"
 			}
 			`,
 		},
+		{
+			name:     "casted const",
+			fileName: "file.go",
+			file: `package main
+
+			import "github.com/nicksnyder/go-i18n/v2/i18n"
+
+			type ConstType string
+
+			const Const ConstType = "my const"
+
+			var m = &i18n.LocalizeConfig{
+				ID: "id",
+				Other: string(Const),
+			}
+			`,
+			activeFile: []byte(`id = "my const"
+`),
+		},
 	}
 
 	for _, test := range tests {