This repository has been archived by the owner on Feb 27, 2019. It is now read-only.
A circular reference bug fix suggestion and a Chinese internationalization file support #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a slight problem may cause memory leak,and here are the steps to reproduce:
Firstly,open your example project.Then open the Main.Storyboard and add a storyboard id to the layout of ViewController as shown in the screenshot:
Secondly,open AppDelegate add source code
UIStoryboard(name: "Main", bundle: nil).instantiateViewController(withIdentifier: "test")
to the callback method "didFinishLaunchingWithOptions" as shown in the screenshot:Finally,run the app,then you can see xcode detects a memory leak form the member variables of PermissionScope as shown in the screenshot:
So,I suggest to add a weak mark to the member variable named viewControllerForAlerts of PermissionScope.And hope it could eliminate the risk of memory leaks.
Thanks for your open source library!And hope you have a nice day!
by:Jason (China 2017.6.9)