This repository has been archived by the owner on Feb 27, 2019. It is now read-only.
Factored permissions out into subspecs #216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow @timothycosta, thank you, this looks like quite a bit of work. I'll review and get back to you on your questions. |
|
@nickoneill Did you ever get a chance to look at this? If you have suggestions for how I can get bluetooth working again I'd be happy to take another stab at it. |
|
@nickoneill any update on this? This change would be very useful. |
|
No, sorry. I'm busy right now and don't have time to work on this project. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've factored out all of the individual permissions into subspecs. However, the subspecs just add swift files into the core framework. They don't result in individual frameworks or use preprocessor macros.
Everything seems to be working except for bluetooth, which relies on a while loop on line 486 of
PermissionScope.swift. I've commented out the loop for the moment as I don't quite understand how it works. It might be a very simple fix.There are a couple of places where I've resorted to
responds(to:)where I wasn't able to abstract out the current logic. It's not pretty, but I don't know a better way to get around the issue without re-architecting everything in order to pull outstatusandrequestinto individual classes. That seems like it would be a good idea long term, and would probably completely sidestep the bluetooth issue.