This repository has been archived by the owner on Feb 27, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 505
Swift3 UserNotifications support #191
Open
robbiet480
wants to merge
11
commits into
nickoneill:master
Choose a base branch
from
robbiet480:swift3-ios10-usernotifications
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Swift3 UserNotifications support #191
robbiet480
wants to merge
11
commits into
nickoneill:master
from
robbiet480:swift3-ios10-usernotifications
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nickoneill The example app is somewhat broken on iOS 10 simulator it seems. It looks like this: |
Hey @robbiet480, that happened occasionally in the iOS 9 simulator as well. I'll check if it's any more reliably broken in the new sim. |
Hey there, any chance you can rebase this against master? Freshly swift3. |
@nickoneill done! |
@nickoneill Hey Nick. We wait for this one to be merged :) Can we do something to speedup the process? |
I'll check this out in the next few days @etartakovsky |
Please merge this - for warning free XCode projects :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #192 for a Swift 2.x version of this code.
Closes #190.