Skip to content
This repository has been archived by the owner on Feb 27, 2019. It is now read-only.

Swift3 UserNotifications support #191

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

robbiet480
Copy link

@robbiet480 robbiet480 commented Sep 9, 2016

See also #192 for a Swift 2.x version of this code.

Closes #190.

@robbiet480 robbiet480 changed the base branch from master to swift3 September 9, 2016 00:58
@robbiet480
Copy link
Author

robbiet480 commented Sep 9, 2016

@nickoneill The example app is somewhat broken on iOS 10 simulator it seems. It looks like this:

screen shot 2016-09-08 at 6 00 29 pm

@nickoneill
Copy link
Owner

Hey @robbiet480, that happened occasionally in the iOS 9 simulator as well. I'll check if it's any more reliably broken in the new sim.

@nickoneill
Copy link
Owner

Hey there, any chance you can rebase this against master? Freshly swift3.

@robbiet480
Copy link
Author

@nickoneill done!

@nickoneill nickoneill changed the base branch from swift3 to master September 26, 2016 23:50
@bre7 bre7 mentioned this pull request Nov 12, 2016
@tartakovsky
Copy link

@nickoneill Hey Nick. We wait for this one to be merged :) Can we do something to speedup the process?

@nickoneill
Copy link
Owner

I'll check this out in the next few days @etartakovsky

@4np
Copy link

4np commented Jan 10, 2017

The code in the pull requests still uses some deprecated categories:

pod 'PermissionScope', :git => 'https://github.com/robbiet480/PermissionScope.git', :branch => 'swift3-ios10-usernotifications'

screen shot 2017-01-10 at 11 43 28

@ogezue
Copy link

ogezue commented Feb 3, 2017

Please merge this - for warning free XCode projects :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants