Skip to content
This repository has been archived by the owner on Feb 27, 2019. It is now read-only.

Customize alerts #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Customize alerts #172

wants to merge 1 commit into from

Conversation

akofman
Copy link

@akofman akofman commented May 26, 2016

I just added some public variables in order to customize the denied and disabled alerts.
I'm not an experimented Swift developper so please let me know whether it's fine for you.

Thanks for your review !

@nickoneill
Copy link
Owner

Thanks @akofman, I can see this being useful.

How are you accessing the pretty permission name used in the default deniedAlertTitle as permission.prettyDescription from your override?

@akofman
Copy link
Author

akofman commented Jun 2, 2016

Hello,

Yep, I don't access it from the override value. I actually tested this case from request* methods and in this particular case it doesn't really matter because I can update the title before displaying the alert. But indeed I didn't think about the dialog :/
Do you have any guidance about that ? Would it be better with something like a template string ?

@akofman
Copy link
Author

akofman commented Jan 23, 2017

Hello @nickoneill,

I have updated/rebased this PR in order to give access to the permission.prettyDescription from the override title and message.

As an example now you can init the PermissionScope instance as following:
pscope.disabledAlertTitle = "Hey ! %@ permission is disabled."

@akofman
Copy link
Author

akofman commented Feb 6, 2017

Bump :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants