Skip to content
This repository has been archived by the owner on Feb 27, 2019. It is now read-only.

Allow more characters and remove the need for hard-coded line breaks in labels #164

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

VFUC
Copy link
Contributor

@VFUC VFUC commented Apr 11, 2016

I localised some strings to German in another PR (#162) and got the (valid) response that the increasing character count would not lay out well.
Considering the possibility of other languages having a similar affection for long words, I think it's not a bad idea to make the labels more flexible.
I put the proposed minimumScaleFactor to 0.75, which in my opinion still qualifies as legible. In the example of the "bodyLabel" it allows for ~100 additional characters.
This also removes the need to add line breaks into the middle of the strings.

@nickoneill
Copy link
Owner

Thanks @VFUC! I'll check this out.

@bre7
Copy link
Collaborator

bre7 commented Apr 11, 2016

Note: Don't forget to update Keys (string files)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants