This repository has been archived by the owner on Feb 27, 2019. It is now read-only.
Allow more characters and remove the need for hard-coded line breaks in labels #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I localised some strings to German in another PR (#162) and got the (valid) response that the increasing character count would not lay out well.
Considering the possibility of other languages having a similar affection for long words, I think it's not a bad idea to make the labels more flexible.
I put the proposed minimumScaleFactor to 0.75, which in my opinion still qualifies as legible. In the example of the "bodyLabel" it allows for ~100 additional characters.
This also removes the need to add line breaks into the middle of the strings.