This repository has been archived by the owner on Feb 27, 2019. It is now read-only.
Fix infinite loop when waiting for motion status #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Navideck-fotis, thanks for reporting this. Does this occur whenever you request motion or just in some unusual cases? |
|
It happens every time. I guess nobody else tested motion or maybe they overlooked it. As an additional safety measure maybe we could add a timeout to the waiting loop. |
|
@nickoneill any updates on this? |
|
I have a day scheduled for open source work early next week, I'll make all these changes and a new release then. |
|
Ping |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a very important issue. I had an infinite loop when I was waiting for motion status. I noticed this accidentally in my app's last version. This used to work and I am not sure what broke it (iOS 9 or some other change in the library) but it should work fine after merging this.