Simplify print_status in rofi-bluetooth #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the mapfile + bash array code with a simple pipe into a while loop and simplifies the logic a bit. It also makes the script more portable. The only remaining bashism is the pair of echo -e "$options" calls, which can be replaced with a slightly uglier printf "$options" if posix compatibility is desired. Then the script runs fine on dash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the mapfile + bash array code with a simple pipe into a while loop and simplifies the logic a bit.
It also makes the script more portable. The only remaining bashism is the pair of echo -e "$options" calls, which can be replaced with a slightly uglier printf "$options" if posix compatibility is desired. The script runs fine on dash.