Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix for Stack with direction='in' #82

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

gauriachalare123
Copy link

@gauriachalare123 gauriachalare123 commented Feb 24, 2020

There is no way to specify max. no of layers for stack. If there are too many overlapping regions and when we specify stack direction = 'in' or 'center' the stack layers are getting plotted outside the specified the inner and outer radius. But in case of direction ='out' the layers are getting hidden . Layers are not getting plotted outside the specified inner and outer radius in case direction = 'out'.
Please refer issue #81

Change in Stack.js

if (this.conf.direction === 'in') {
return [
Math.max(this.conf.outerRadius - radialEnd, this.conf.innerRadius),
Math.max(this.conf.outerRadius - radialStart,this.conf.innerRadius)

  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant