Implement native scroll containers in HTML renderer #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for native
overflow: scrollcontainers to the HTML renderer, which significantly improves scrolling performance for older devices and safari.See it in action right now at https://nicbarker.com/clay
Essentially I'm reversing the source of truth - Clay has a new API to call to query the current scroll position of containers, and it's up to the HTML side to actually perform the scrolling.
This has the natural side effect of creating out of the box support for all types of scrolling and customisation naturally supported by the browser, e.g. configurable scroll speed, support for HOME / END keys, etc.