-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the NGXS Data Plugin's ReadMe Path #1962
base: master
Are you sure you want to change the base?
Updated the NGXS Data Plugin's ReadMe Path #1962
Conversation
Pointed to [non-deprecated repository](https://github.com/Angular-RU/angular-ru-sdk/tree/master/libs/ngxs) with correct ReadMe Path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the development of what used to be the @ngxs-labs/data
plugin has moved to @angular-ru/ngxs
.
I think that it may be better to make the note here that the @ngxs-labs/data
has been deprecated and refer to the replacement plugin, listing this plugin in a separate line.
@splincode please confirm if this is what you would like to be done here?
@splincode Any thoughts on this (see my comment☝️) ? |
@splincode Any feedback (see my comment☝️) ? |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 59d40c2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
Code Climate has analyzed commit 59d40c2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.5% (0.0% change). View more on Code Climate. |
BundleMon (Integration Projects)Unchanged files (2)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
docs(ReadMe): @ngxs-labs/data plugin links to deprecated ReadMe
Updated ReadMe Path to non-deprecated repository
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ReadMe.md directs
@ngxs-labs/data
plugin ReadMe to deprecated repositoryIssue Number: N/A
What is the new behavior?
Correct Repository is Linked
Does this PR introduce a breaking change?
Other information