Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow nullable values again #122

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix: allow nullable values again #122

merged 1 commit into from
Jul 5, 2024

Commits on Jul 5, 2024

  1. fix: allow nullable values again 

    Closes: ngneat#119
Angular 18 requires TS 5.4+ which breaks the NonNullable type:
microsoft/TypeScript#56644
This reintroduces issue ngneat#81.
This commit replaces NonNullable with Exclude to allow correct typing of
ExtractRefProp and fix the issue where opening dialogs containing
undefined values throws TS2769 when trying to set the data property.
    @jacobg213
    jacobg213 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    86f6605 View commit details
    Browse the repository at this point in the history