Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fixes #77

Merged
merged 2 commits into from
Nov 19, 2024
Merged

CI fixes #77

merged 2 commits into from
Nov 19, 2024

Conversation

p-pautov
Copy link
Contributor

Proposed changes

Renamed CI file to match the OS, assuming we'll name Alpine file in the same manner.

Added pull requests trigger for CI. Apparently, we don't run it currently for external contributor requests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes

@p-pautov p-pautov requested a review from jimf5 November 19, 2024 22:43
@p-pautov
Trigger CI build on pull requests.
1a4c731 
Also, use default 'run-name' for more informative message.
jimf5
jimf5 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@jimf5 jimf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p-pautov p-pautov merged commit da2e4eb into main Nov 19, 2024
2 checks passed
@p-pautov p-pautov deleted the ci_fixes branch November 19, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimf5 jimf5 jimf5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-pautov @jimf5