Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep repo key registered in alpine, and simplify Dockerfiles #874

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Mar 21, 2024

Proposed changes

Simplify package installation in non-slim variants.

This can also be used in user images to install packages directly.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • I have run ./update.sh and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation

@thresheek
Copy link
Collaborator

Hi @orgads !

We did that because we explicitely did not want the image to have the repository configured - as adding more packages with the repos configured might upgrade the packages to something newer than specified initially. This is also consistent with what we have for Debian-based images.

@orgads
Copy link
Contributor Author

orgads commented Mar 22, 2024

I see. I now changed it to just keep the key registered, but not register the repo. I see this is also done in debian. What do you say?

@orgads orgads changed the title Alpine: Register repo and simplify Dockerfiles Keep repo key registered in alpine, and simplify Dockerfiles Mar 22, 2024
@orgads
Copy link
Contributor Author

orgads commented Mar 22, 2024

And simplified debian perl and otel to use the existing key too.

In debian image, the key is not deleted.

This can also be used in user images to install packages directly.
@thresheek thresheek merged commit b7a3296 into nginxinc:master Apr 23, 2024
9 checks passed
@thresheek
Copy link
Collaborator

Thanks @orgads !

@orgads orgads deleted the alpine-repo branch April 23, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants