-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .clang-format file with Unit ruleset #1469
base: master
Are you sure you want to change the base?
Conversation
db7097d
to
3ad3d53
Compare
@javorszky What's the current diff if you apply these rules to Unit? |
How was this file generated and where do all the comments come from? |
Originally with Every comment is written by hand by me. |
Hmm
|
need clang-format v20.0.0 sadly |
That's way too new!, it's not even released yet, probably in March next year... |
I'll put up a new version with the v20 rules removed, and a diff for this, and all the other prebuilt styles as well |
3ad3d53
to
c19de3d
Compare
This has been updated so clang-format 19 will take it. I've also updated the main comment to point to a bunch of different draft PRs for the reformats. (if you don't see it, I'm still pushing / opening them) |
This adds a
.clang-format
file that can be used with theclang-format
tool to either reformat code locally, or automatically flag up code styling issues during a github action.This PR's only aim right now is to have a conversation about the rulesets and come to a standard (ie ruleset in the clang-format file) that the entire team agrees on, so we can get to a point where we're not having conversations about code styling in future PRs.
This PR does not aim to wire it up to github actions yet.
Diffs of the codebase: