NGINX plus receiver #742
Open
NGINX plus receiver #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add unit test with fairly extensive mock responses * Fix units in metadata.yaml
dhurley
requested review from
oliveromahony,
craigell,
olli-holmala,
spencerugbo and
aphralG
github-actions
bot
added
chore
olli-holmala
approved these changes
Jul 10, 2024
aphralG
reviewed
Jul 18, 2024
| func (oc *Collector) handleNginxConfigUpdate(ctx context.Context, msg *bus.Message) { | ||
| nginxConfigContext, ok := msg.Data.(*model.NginxConfigContext) | ||
| if !ok { | ||
| slog.ErrorContext(ctx, "Unable to cast message payload to *model.NginxConfigContext", "payload", msg.Data) |
There was a problem hiding this comment.
Probably need a return here too.
Suggested change
| slog.ErrorContext(ctx, "Unable to cast message payload to *model.NginxConfigContext", "payload", msg.Data) | |
| slog.ErrorContext(ctx, "Unable to cast message payload to *model.NginxConfigContext", "payload", msg.Data) |
Suggested change
| slog.ErrorContext(ctx, "Unable to cast message payload to *model.NginxConfigContext", "payload", msg.Data) | |
| slog.ErrorContext(ctx, "Unable to cast message payload to *model.NginxConfigContext", "payload", msg.Data) | |
| return |
| errChan := make(chan error) | ||
|
|
||
| oc.stopped = false |
There was a problem hiding this comment.
Just a side note, should we toggle this to true when we receive an error from oc.service.Run(ctx) and/or when state is otelcol.StateClosed in the for loop below?
| @@ -117,19 +119,182 @@ func (oc *Collector) Close(ctx context.Context) error { | |||
| slog.InfoContext(ctx, "Closing OTel Collector plugin") | |||
|
|
|||
| if !oc.stopped { | |||
| slog.InfoContext(ctx, "Shutting down OTel Collector", "state", oc.service.GetState()) | |||
| oc.stopped = true | |||
There was a problem hiding this comment.
Just in the interest of correctness, should we toggle this only when state is otelcol.StateClosed in our backoff function?
olli-holmala
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)