Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEFAULT_RENEW variable #896

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

chinkung
Copy link

@chinkung chinkung commented Dec 2, 2021

Allow to override day to renew the cert.

Certificate from some CA like Buypass has 180 days lifetime, so you might want to renew it at day 170 instead of day 60

See https://github.com/acmesh-official/acme.sh/wiki/BuyPass.com-CA

@buchdag buchdag added the type/feat PR for a new feature label Dec 7, 2021
@buchdag

This comment has been minimized.

@buchdag buchdag added the status/pr-needs-tests This PR needs new or additional test(s) label Dec 8, 2021
@chinkung
Copy link
Author

@buchdag

I just add test unit, could you please review ?

@Itebo-E-Services-Development

Are there any estimates on if/when this could be merged?

@toheide
Copy link

toheide commented Dec 11, 2023

This would be really helpful, especially for in-house CAs with a even shorter forced refresh cycle than the default 60 days. acme-companion does currently not work with shorter CA policies, that issue certificates only for 30 days. @buchdag

@sparchatus
Copy link

Something I could do to help move this along?

@buchdag buchdag removed the status/pr-needs-tests This PR needs new or additional test(s) label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feat PR for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants