Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed param name typo #167

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NicosKaralis
Copy link

There is a typo setting horizontal center, the way it is it will never even attempt to center the glyph

This should be enough to fix it

@@ -489,7 +489,7 @@ class SVGIcons2SVGFontStream extends Transform {
glyphPath.getBounds();
if (this._options.centerHorizontally) {
glyphPath.translate(
(glyph.width - (bounds.maxX - bounds.minX)) / 2 - bounds.minX
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% on this

To me this solved my issues with misaligned glyphs but it's best if someone that understands this better gives some feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant