Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MetaMaps classifier #496

Draft
wants to merge 1 commit into
base: bouncy-basenji
Choose a base branch
from
Draft

Add MetaMaps classifier #496

wants to merge 1 commit into from

Conversation

sofstam
Copy link
Collaborator

@sofstam sofstam commented Jun 13, 2024

Closes #70

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/taxprofiler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@sofstam sofstam changed the title Start adding metamaps classifier Add MetaMaps classifier Jun 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d0262a6

+| ✅ 263 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-13 15:01:00

@sofstam
Copy link
Collaborator Author

sofstam commented Jul 16, 2024

DiltheyLab/MetaMaps#74 (comment)

I close this PR for the time being.

@sofstam sofstam closed this Jul 16, 2024
@jfy133
Copy link
Member

jfy133 commented Jul 16, 2024 •
edited
Loading

@sofstam I would not close it but rather just convert it to draft, so we don't lose it!

@sofstam
Copy link
Collaborator Author

sofstam commented Jul 16, 2024 •
edited
Loading

Good point, it was already a draft.

@sofstam sofstam reopened this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sofstam @jfy133