Important! Template update for nf-core/tools v2.14.1 #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpatelh
reviewed
May 13, 2024
Comment on lines
+317
to
+318
| - `wave` | ||
| - A generic configuration profile to enable [Wave](https://seqera.io/wave/) containers. Use together with one of the above (requires Nextflow ` 24.03.0-edge` or later). |
There was a problem hiding this comment.
@maxulysse we need to update this in the template if we rename the profile as in #1291
There was a problem hiding this comment.
Indeed, I was thinking the exact same
There was a problem hiding this comment.
Are we 100% sure with the name?
drpatelh
reviewed
May 13, 2024
Comment on lines
+317
to
+318
| - `wave` | ||
| - A generic configuration profile to enable [Wave](https://seqera.io/wave/) containers. Use together with one of the above (requires Nextflow ` 24.03.0-edge` or later). |
There was a problem hiding this comment.
Suggested change
| - `wave` | |
| - A generic configuration profile to enable [Wave](https://seqera.io/wave/) containers. Use together with one of the above (requires Nextflow ` 24.03.0-edge` or later). | |
| - `seqera_containers` | |
| - A generic configuration profile to enable [Wave](https://seqera.io/wave/) and to build and pull from the Seqera containers repository. Use together with one of the above (requires Nextflow ` 24.03.0-edge` or later). |
There was a problem hiding this comment.
If this originates in the template we should update it there first.
There was a problem hiding this comment.
Yep, we can update it in #1291 first so everything is updated as an example, and then push to the template. Think we have some agreement but will allow time for more discussions.
There was a problem hiding this comment.
@maxulysse when we have merged this PR can you pull in the changes from dev and make this update in #1291 please?
|
maxulysse
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
2.14.1of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the
nf-core-template-merge-2.14.1branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.
For more information about this release of nf-core/tools, please see the
v2.14.1release page.