Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request - trying to add BSSNPer #223

Closed
wants to merge 11 commits into from
Closed

Conversation

AliaMW
Copy link

@AliaMW AliaMW commented Nov 25, 2021

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/methylseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Adding intermediate step - add readgroups to BAM files - before adding BisSNP
Added new process AFTER markDuplicates to call SNPs
Added extra channel in markDuplicates output for new process
Change it eventually
@github-actions

This comment has been minimized.

@AliaMW AliaMW changed the base branch from master to dev November 25, 2021 10:54
@ewels ewels added the dsl1 label Nov 8, 2022
@sateeshperi
Copy link
Contributor

hi @AliaMW could i ask about the status of this PR?

@sateeshperi
Copy link
Contributor

sateeshperi commented Sep 17, 2024

hi @AliaMW the pipeline will have changed much to accommodate these changes. If you are still interested in contributing this process, I would recommend incorporating BSSNPer as an nf-core module and then importing it into the pipeline rather than a local process.

I will close this PR for now. Kindly reach out if you need any clarification or help. Thanks

@sateeshperi sateeshperi added the WIP Work in progress label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dsl1 WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants