Expo upgrade to 51 #30
Conversation
|
@SeanMGonzalez is attempting to deploy a commit to the Team Neynar's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
@SeanMGonzalez I left a few comments but otherwise the rest looks good!
| @@ -9,27 +9,28 @@ | |||
| "web": "expo start --web" | |||
| }, | |||
| "dependencies": { | |||
| "@coinbase/coinbase-sdk": "^4.0.4", | |||
There was a problem hiding this comment.
Would you be able to downgrade to v0.2.0? That's the latest version I see on npm
| @@ -4,6 +4,10 @@ import Image from "next/image"; | |||
| import Link from "next/link"; | |||
| import { ReactNode, useEffect } from "react"; | |||
|
|
|||
| import { useAccount } from 'wagmi'; // coinbase | |||
There was a problem hiding this comment.
could you remove a few of the miscellaneous coinbase comments?
| ? 'http://localhost:3000' | ||
| : 'https://onchain-app-template.vercel.app'; | ||
| // Add your API KEY from the Coinbase Developer Portal | ||
| export const NEXT_PUBLIC_CDP_API_KEY = process.env.NEXT_PUBLIC_CDP_API_KEY; |
There was a problem hiding this comment.
Would you be able to add a corresponding comment in the README that the developer would have to get credentials from Coinbase Developer Platform when filling out their .env file?
upgraded expo from 49 to 51, IP detection, README IP protip