Default revision #5610
Draft
Default revision #5610
+710
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for nextflow-docs-staging failed. Why did it fail? →
|
- Implemented `getDefaultRevision()` method in `Manifest.groovy` to retrieve the default revision. - Updated `AssetManager.groovy` to compare the current revision against the default revision instead of the default branch during checkout.
…efaultRevision scenarios - Added tests to verify behavior of AssetManager when handling defaultBranch and defaultRevision configurations. - Implemented scenarios for defaultBranch set to 'master', defaultRevision specified, and version as defaultRevision. - Included tests for cases with no defaultBranch and fallback mechanisms to ensure correct defaults are applied. - Ensured that commit hashes can be used as defaultRevision and validated the handling of version tags in absence of defaultBranch. - Marked several tests as PendingFeature for future implementation. refactor: Remove PendingFeature annotations from AssetManagerTest - Removed @PendingFeature annotations from multiple test cases in AssetManagerTest.groovy. - This change indicates that the tests are now fully implemented and ready for execution. - The tests cover scenarios for defaultBranch and defaultRevision configurations, ensuring comprehensive validation of AssetManager behavior.
- Removed @PendingFeature annotations from multiple test cases, indicating they are fully implemented. - Added comprehensive tests for AssetManager's handling of defaultBranch and defaultRevision configurations. - Implemented scenarios for various configurations, including defaultBranch set to 'master', specific defaultRevision, and version as defaultRevision. - Validated behavior for cases with no defaultBranch and ensured correct fallback mechanisms. - Enhanced tests for resolving script names and managing repository providers across different platforms.
…onsolidating configurations - Removed several test cases that were redundant or overly complex, focusing on essential scenarios for AssetManager's behavior. - Consolidated Git configuration tests into static final strings for better readability and maintainability. - Streamlined the setup process for tests, ensuring clarity in the initialization of AssetManager instances. - Enhanced the clarity of the remaining tests by improving comments and structure, making it easier to understand the purpose of each test case.
edmundmiller
force-pushed
the
default-revision
branch
from
2da6757 to
d1ebdcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4427
Need to clean up this PR a bit, and test it out in a real-world, not just in tests.