Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'defaults' conda channel from docs. #5607

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

ewels
Copy link
Member

@ewels ewels commented Dec 13, 2024

Fixes #5601

@ewels ewels requested a review from a team as a code owner December 13, 2024 13:08
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit b25862c
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/675ff6d486c97b00087bb0ba

@christopher-hakkaart
Copy link
Contributor

Looks good to me.

@pditommaso
Copy link
Member

Failing tests 😢

@bentsherman
Copy link
Member

@ewels you need to either revert the changes to CondaCacheTest or update the expected conda hashes in those tests. Your choice 😅

@ewels
Copy link
Member Author

ewels commented Dec 13, 2024

I was hoping that the CI would print out the new hash in the log when it failed, so that I could just copy it in without running anything locally. However no such luck by the look of it 😢

@bentsherman
Copy link
Member

You have to download the test report given under "Publish tests report" to see that. Or run the test locally, it gives you the same report

Signed-off-by: Phil Ewels <[email protected]>
@ewels
Copy link
Member Author

ewels commented Dec 16, 2024

@bentsherman thank you! I'd forgotten that this existed. Would be fun to set up a GitHub action to post a link to these assets as a comment on the PR if the tests fail!

@pditommaso pditommaso merged commit 8b54181 into nextflow-io:master Dec 16, 2024
22 checks passed
@ewels ewels deleted the docs-no-defaults branch December 16, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Conda defaults channel from documentation or put disclaimer
4 participants