Fixing getRepositoryURL when project-name not provided #5560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorgee <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
jorgee
changed the title
pditommaso
reviewed
Dec 9, 2024
modules/nextflow/src/main/groovy/nextflow/scm/AzureRepositoryProvider.groovy
Outdated
Show resolved
Hide resolved
…rovider.groovy [ci skip] Signed-off-by: Paolo Di Tommaso <[email protected]>
pditommaso
reviewed
Dec 9, 2024
modules/nextflow/src/main/groovy/nextflow/scm/AzureRepositoryProvider.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: jorgee <[email protected]>
pditommaso
approved these changes
Dec 9, 2024
pditommaso
added a commit
that referenced
this pull request
Dec 16, 2024
Signed-off-by: jorgee <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getRepositoryUrlin SCM Azure provider is returning an incomplete URL when organization-name/project-name/repo-name is provided. It is mainly caused because the project-name seems optional and the repo-name is only includedRepositoryProvider.projectvariable when project-name is not provided.Just a adding a flag to indicate when project-name and use it in the
getRepositoryUrlto include the repo name seems enough to fix the issue.I think in Nextflow the
getRepositoryUrlis mainly used for logging purposes and unit tests, because there was no error pulling the repositories using both options (with and without project-name)