-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PBSPRO queue status fetch #5529
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: HDash <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
I have a sneaking suspicion that this worked on whatever PBSPro cluster it was tested on, and maybe the status text changed across different versions. It would be good to have some clear documentation on how the status text is supposed to look, so that we can test against it, like here: nextflow/modules/nextflow/src/test/groovy/nextflow/executor/PbsProExecutorTest.groovy Lines 219 to 238 in fa0e8e0
At the same time, I'm pretty sure the PBSPro executor was added at my request, to support my university cluster 😅 And I do remember seeing these "failed to fetch queue status" warnings but I never figured out why they were happening |
Hello @bentsherman, You are correct—I’ve been encountering this issue on Imperial’s cluster. It seems that The job state parsing portion of the code, however, appears to work perfectly and functions as intended. The failure lies in fetching the job state strings. With my fork, Job Id: 297959.pbs
job_state = Q Which is exactly what we want. My queued job is labelled appropriately. For current version, qstat: illegally formed destination: @ |
Closes #5528
A simple conditional
if
statement to check if the output is empty fixes the issue.